Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] docs: refactoring Usage Insights #2267

Merged
merged 5 commits into from
Jun 16, 2023
Merged

[BD-46] docs: refactoring Usage Insights #2267

merged 5 commits into from
Jun 16, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented May 5, 2023 •
edited
Loading

Description

Issue: #2318

Deploy Preview

Usage Insights

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 5, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 5, 2023 •
edited
Loading

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented May 5, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ffffcfe
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/646b184fec4a970007f98971
😎 Deploy Preview https://deploy-preview-2267--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/refactoring-usage-insights branch from 9878669 to 1d4b9da Compare May 5, 2023 06:58
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (d9f6650) 91.38% compared to head (ffffcfe) 91.38%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2267   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         234      234           
  Lines        4120     4120           
  Branches      982      982           
=======================================
  Hits         3765     3765           
  Misses        348      348           
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov viktorrusakov marked this pull request as draft May 5, 2023 08:56
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/refactoring-usage-insights branch 3 times, most recently from f2d7cd2 to c749d4e Compare May 21, 2023 10:12
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/refactoring-usage-insights branch from c749d4e to 37b283e Compare May 21, 2023 10:28
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/refactoring-usage-insights branch from 6c879ad to a3e58df Compare May 21, 2023 13:47
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 22, 2023 07:07
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFT: refactoring Usage Insights [BD-46] docs: refactoring Usage Insights May 22, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request May 22, 2023
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/refactoring-usage-insights branch from 78a35a4 to ffffcfe Compare May 22, 2023 07:22
@viktorrusakov viktorrusakov linked an issue May 26, 2023 that may be closed by this pull request
[Usage Insights] Component type is missing in subcomponents #2318
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang requested review from monteri and removed request for viktorrusakov June 14, 2023 15:14
adamstankiewicz
adamstankiewicz approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job cleaning up these "Usage Insights" related files! Should be more maintainable /
understandable / approachable moving forward.

www/gatsby-node.js Show resolved Hide resolved
www/src/utils/getParagonComponentsTypes.js
Comment on lines +11 to +13
case componentName.toLowerCase() === 'paragon':
componentType = 'Paragon';
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; didn't know we had a usage of import * as paragon from '@edx/paragon';!

www/utils/createPages.js
}
`);
if (result.errors) {
reporter.panicOnBuild('🚨 ERROR: Loading createPages query');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lol at this function name panicOnBuild)

@adamstankiewicz adamstankiewicz merged commit 2b8a1f3 into openedx:master Jun 16, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

@monteri monteri Awaiting requested review from monteri

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Usage Insights] Component type is missing in subcomponents
4 participants
@PKulkoRaccoonGang @openedx-webhooks @edx-semantic-release @adamstankiewicz